Flink: Backport #6660 to Flink 1.14 and 1.15 #6949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
force-pushed
the
flink-branch-write-backports
branch
from
795f543 to
5d69daf
Compare
| long durationMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNano); | ||
| LOG.info( | ||
| "Committed {} to table: {}, checkpointId {} in {} ms", | ||
| "Committed {} to table: {}, branch: {}, checkpointId {} in {} ms", |
Contributor
Author
There was a problem hiding this comment.
@stevenzwu I added this log for branch when backporting, noticed we were missing the branch after the operation actually committed. I'll add this to Flink 1.16 in a separate PR. Let me know your thoughts.
Contributor
There was a problem hiding this comment.
I will be fine if you just add it in this PR.
Can you check the diff output and make sure no diff related to this backport?
git diff --no-index flink/v1.14/flink/src/ flink/v1.16/flink/src
git diff --no-index flink/v1.15/flink/src/ flink/v1.16/flink/src
Contributor
Author
There was a problem hiding this comment.
Checked, verified there's no diff related to this backport.
amogh-jahagirdar
changed the title
amogh-jahagirdar
force-pushed
the
flink-branch-write-backports
branch
from
5d69daf to
5a2b8ea
Compare
amogh-jahagirdar
force-pushed
the
flink-branch-write-backports
branch
from
5a2b8ea to
2ec3d41
Compare
Contributor
Author
|
I rebased , saw there were some new changes and test additions. No conflicts but want to make sure tests pass after rebasing. |
stevenzwu
approved these changes
Feb 28, 2023
Contributor
|
thanks @amogh-jahagirdar for the backport |
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport https://github.com/apache/iceberg/pull/6660/files