Skip to content

Conversation

@vrozov
Copy link
Member

@vrozov vrozov commented Jan 9, 2019

Closes #53

@vrozov
Copy link
Member Author

vrozov commented Jan 9, 2019

@rdblue Please review

@mccheah
Copy link
Contributor

mccheah commented Jan 22, 2019

Conflicts in a lot of places. Think it would be great to take a look at this soon - would like this to unblock code linting work for 1.x too.

@rdblue
Copy link
Contributor

rdblue commented Jan 22, 2019

Yeah, I haven't looked at this much because I think we will want to plan when we switch over. It will break other pull requests. It's also a fairly simple change in an IDE, so I wouldn't worry about the conflicts. We can just refactor when the time comes.

@xabriel xabriel mentioned this pull request Mar 5, 2019
@rdblue
Copy link
Contributor

rdblue commented Mar 24, 2019

This was done by #138. I'm going to close this PR.

@rdblue rdblue closed this Mar 24, 2019
@vrozov vrozov deleted the incubator-iceberg-53 branch May 9, 2019 22:01
jun-ma-0 pushed a commit to jun-ma-0/incubator-iceberg that referenced this pull request May 11, 2020
[PLAT-51222] Use iterator for expression instead of recursion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants