Spark: DROP BRANCH SQL implementation #6752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
commented
Feb 6, 2023
.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
commented
Feb 6, 2023
...extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropBranchExec.scala
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
commented
Feb 6, 2023
...extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropBranchExec.scala
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
commented
Feb 6, 2023
.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
drop-branch
branch
from
d225fe1 to
a53d860
Compare
amogh-jahagirdar
force-pushed
the
drop-branch
branch
2 times, most recently
from
a66b371 to
b8cade0
Compare
singhpk234
reviewed
Feb 6, 2023
...extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropBranchExec.scala
Outdated
Show resolved
Hide resolved
...extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropBranchExec.scala
Outdated
Show resolved
Hide resolved
...sions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
Outdated
Show resolved
Hide resolved
.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java
Outdated
Show resolved
Hide resolved
.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 6, 2023
.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 6, 2023
.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
drop-branch
branch
from
b8cade0 to
79ea243
Compare
hililiwei
reviewed
Feb 7, 2023
.../scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala
Outdated
Show resolved
Hide resolved
hililiwei
reviewed
Feb 7, 2023
...sions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
drop-branch
branch
7 times, most recently
from
261249c to
2040da3
Compare
singhpk234
reviewed
Feb 8, 2023
...k/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java
Show resolved
Hide resolved
...k/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java
Outdated
Show resolved
Hide resolved
...k/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
drop-branch
branch
from
2040da3 to
22fbae9
Compare
singhpk234
approved these changes
Feb 8, 2023
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, Thanks @amogh-jahagirdar !!
Co-authored-by: liliwei [email protected] Co-authored-by: xuwei [email protected] Co-authored-by: chidayong [email protected]
amogh-jahagirdar
force-pushed
the
drop-branch
branch
from
22fbae9 to
77dffba
Compare
Contributor
|
Looks like all comments are addressed and we have enough vote, I will go ahead and merge this. We can address further comments in the subsequent DROP TAG PR if necessary. Thanks for the work @amogh-jahagirdar & @hililiwei , and thanks for everyone's review! |
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
Co-authored-by: liliwei [email protected] Co-authored-by: xuwei [email protected] Co-authored-by: chidayong [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of DROP BRANCH Spark SQL
Co-authored-by: liliwei [email protected]
Co-authored-by: xuwei [email protected]
Co-authored-by: chidayong [email protected]
CC: @jackye1995 @hililiwei @flyrain @singhpk234 @aokolnychyi