Skip to content

Docs: Add the description of creating a table using DataFrameWriterV2 with a table location #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szehon-ho merged 4 commits into from
Feb 28, 2023
Merged

Docs: Add the description of creating a table using DataFrameWriterV2 with a table location #6729

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9178194
Add the description of createTable using DataFrameWriterV2 with a tab…
tomtongue Feb 3, 2023
1ef3c67
Merge branch 'apache:master' into doc-dfv2-location
tomtongue Feb 10, 2023
ca72484
Merge branch 'apache:master' into doc-dfv2-location
tomtongue Feb 28, 2023
30b24fc
Reflect the discussion; https://github.com/apache/iceberg/pull/6729\#…
tomtongue Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/spark-writes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,14 @@ data.writeTo("prod.db.table")
.createOrReplace()
```

You can specify an Iceberg table location such as the `LOCATION` clause in SQL by add the `location` paramter to the `tableProperty`:
Copy link
Member

@szehon-ho szehon-ho Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I know there's a bad example above, but typically we avoid 'you' or 'me' in documentation. you can see other reviews, for example: #4301 (comment)

Also, I'm not sure why we reference "LOCATION" clause in SQL, which is documented elsewhere.

How about:
The Iceberg table location can also be specified by the `location` table configuration

Let me know what you think

Copy link
Contributor Author

@tomtongue tomtongue Feb 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing this and the great suggenstion, Szehon! The following your suggestion is simpler and makes sense. Based on your suggestion, I updated a bit; ... table configuration to table property. How about this?

The Iceberg table location can also be specified by the `location` table property.

For your comment;

Nit: I know there's a bad example above, but typically we avoid 'you' or 'me' in documentation. you can see other reviews, for example: #4301 (comment)

Thanks for pointing out, I understand it.

Also, I'm not sure why we reference "LOCATION" clause in SQL, which is documented elsewhere.

I tried saying the tableProperty("location", "...") is the same as LOCATION in SQL, but the suggestion is better.

Copy link
Member

@szehon-ho szehon-ho Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that will work. Thanks!


```scala
data.writeTo("prod.db.table")
.tableProperty("location", "/path/to/location")
.createOrReplace()
```

## Writing to partitioned tables

Iceberg requires the data to be sorted according to the partition spec per task (Spark partition) in prior to write
Expand Down