Spark: Fix isIcebergCommand check and style issues from #6638

[amogh-jahagirdar]

@hililiwei @jackye1995 @flyrain @yyanyy When working on the drop branch implementation, I noticed that the "or" condition for replace branch wasn't placed right in #6638 . It should be within the startsWith("alter table") condition, but currently its outside. The Iceberg DDL will still work, but the check should be more specific to match the alter table condition to prevent any future spark sql syntax change from being bypassed in the isIcebergCommand check.

Just raising this PR separately since it's a bugfix (albeit for an unlikely case)

[jackye1995]

oh nice catch, did not realize this at all

[jackye1995]

Thanks for the fixes, let's definitely enable scala checkstyle asap to avoid issues like this.

Also I think there are some other fixes in the tests that Liwei found, could you also fix those?

And the title of the PR should probably change.

[amogh-jahagirdar]

Thanks for the fixes, let's definitely enable scala checkstyle asap to avoid issues like this.

Also I think there are some other fixes in the tests that Liwei found, could you also fix those?

And the title of the PR should probably change.

Done! Agreed I created #6736, to track this to avoid reviewers having to spend time on style issues in the scala codebase. I'm looking into it.

Thanks for the reviews @jackye1995 @hililiwei @yyanyy

[jackye1995]

Thanks, I will merge the change for now, as you are working on fixing Scala checkstyle, we can make any missing changes with that.