Use a separate executor service for the concurrent Hive test #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for fixing this, @aokolnychyi! |
jun-ma-0
pushed a commit
to jun-ma-0/incubator-iceberg
that referenced
this pull request
May 11, 2020
@trivial: add SOURCE_SNAPSHOT_ID_PROP from Iceberg's PR apache#695
puchengy
added a commit
to puchengy/iceberg
that referenced
this pull request
Sep 5, 2023
… multi-thread to read parquet file metadata to speed up partition imports (apache#67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a separate executor service for
HiveTablesTest$testConcurrentFastAppends.Right now, the test depends on the size of the worker pool. If the size is less 3, the test will not complete as the same worker pool is used in
SnapshotUpdate$apply(because manifest lists are now enabled and it requires at least one thread).The executor service does not use a custom
ThreadFactory. Threads will be non-daemon, but shouldn't be a problem as the result is wrapped intoMoreExecutors.getExitingExecutorService.