-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Doc: Add a page explaining migration from other table formats to iceberg #6600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Add a page explaining migration from other table formats to iceberg #6600
Conversation
|
I think this can fix #6770 , can we update this page to a dedicated page for all migration use cases and also include Hive to Iceberg? |
72926c1 to
198f389
Compare
JonasJ-ap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackye1995 Thanks for the review. I updated the pages and made up two html preview here:
https://drive.google.com/drive/folders/1XNZ1s2rXNSUxpP_ccUBVockV5KZ3gMOG?usp=share_link
(Since github does not allow me to upload html files directly)
Signed-off-by: Rushan Jiang <[email protected]>
Signed-off-by: Rushan Jiang <[email protected]>
Signed-off-by: Rushan Jiang <[email protected]>
|
Thanks for keeping the work going on! I think we are very close, just 3 nit comments and we should be good to go! Let me know when you have another look |
Signed-off-by: Rushan Jiang <[email protected]>
Signed-off-by: Rushan Jiang <[email protected]>
Signed-off-by: Rushan Jiang <[email protected]>
Signed-off-by: Rushan Jiang <[email protected]>
jackye1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
|
Thanks for all the work Jonas, merging |
RussellSpitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
| ``` | ||
| See [Spark Procedure: migrate](../spark-procedures/#migrate) for more details. | ||
|
|
||
| ## Add Files From Delta Lake Table to Iceberg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say hive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Thank you for catching this. Sorry for the typo.
Have opened a new PR here: #7407, to address that.
|
Thanks! |
Add documentation for the
iceberg-delta-lakemodule created in #6449 and pointers to Hive/Spark table migration procedures specified in Spark Doc.Closes #6770