Core: Avoid creating new metadata file when registerTable API is used
#6591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krvikash
changed the title
registerTable API is usedregisterTable API is used
krvikash
changed the title
registerTable API is usedregisterTable API is used
krvikash
force-pushed
the
avoid-creating-new-metadata-file-in-register-table
branch
from
c8cb001 to
f597ce3
Compare
ajantha-bhat
approved these changes
Jan 17, 2023
Member
ajantha-bhat
left a comment
ajantha-bhat
left a comment
There was a problem hiding this comment.
LGTM.
PR description can be simplified by just keeping Core: instead of all the modules.
krvikash
changed the title
registerTable API is usedregisterTable API is used
krvikash
force-pushed
the
avoid-creating-new-metadata-file-in-register-table
branch
from
f597ce3 to
cda5a05
Compare
szehon-ho
reviewed
Jan 20, 2023
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Makes sense to me, left some style comments
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
HiveTableOperations and NessieTableOperations were already handling this case, but other table operations are missing this case.
krvikash
force-pushed
the
avoid-creating-new-metadata-file-in-register-table
branch
from
cda5a05 to
85aaf12
Compare
szehon-ho
reviewed
Jan 23, 2023
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments. One more small one, and if it is not too much trouble, could we add a unit test in TestHiveCatalog for it for registerTable?
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
avoid-creating-new-metadata-file-in-register-table
branch
from
cc1e34d to
ccc8666
Compare
Member
|
Thanks @krvikash looks good to me, just wanted to see if we can add a test in TestHiveCatalog? (Ignore if you read already and still working on it) |
Contributor
Author
|
Thanks, @szehon-ho for reviewing. Sorry, I missed adding a test case in |
szehon-ho
reviewed
Jan 25, 2023
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Thanks for adding test, one comment about that
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
Outdated
Show resolved
Hide resolved
szehon-ho
approved these changes
Jan 25, 2023
krvikash
force-pushed
the
avoid-creating-new-metadata-file-in-register-table
branch
2 times, most recently
from
5dca53e to
b146e87
Compare
krvikash
force-pushed
the
avoid-creating-new-metadata-file-in-register-table
branch
from
b146e87 to
05cccd6
Compare
Member
|
Thanks for last changes, Ill commit this tomorrow unless there's more comments. |
Contributor
Author
|
Thanks, @szehon-ho | @ajantha-bhat for reviewing the PR. |
Member
|
Merged, thanks @krvikash for change, @ajantha-bhat for review |
krvikash
deleted the
avoid-creating-new-metadata-file-in-register-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HiveTableOperationsandNessieTableOperationswere already handling this case, but other table operations are missing this case.Follow up of #6512 (comment)