Core: Support access to response headers from POST requests #6578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Jan 13, 2023
nastra
force-pushed
the
rest-client-send-headers
branch
from
03e8e0e to
1ff500b
Compare
nastra
force-pushed
the
rest-client-send-headers
branch
from
1ff500b to
1afde07
Compare
Contributor
Author
|
We dicussed offline with @danielcweeks and @rdblue to slim down the PR to only cover |
nastra
changed the title
danielcweeks
approved these changes
Jan 18, 2023
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some context: In #6169 (comment) we're sending back a
cache-controlheader to indicate to the client whether something can be safely cached or not.However, our
HTTPClientdidn't have a way to retrieve the response headers from a given request, so a workaround in #6169 was done, where response headers are sent back as part of the actual response.