Core: View history entry core implementation #6565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
reviewed
Jan 11, 2023
jackye1995
reviewed
Jan 11, 2023
core/src/main/java/org/apache/iceberg/view/BaseViewHistoryEntry.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jan 11, 2023
core/src/main/java/org/apache/iceberg/view/ViewHistoryEntryParser.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jan 11, 2023
amogh-jahagirdar
force-pushed
the
view-history-entry-core
branch
4 times, most recently
from
45fac9e to
c95e4a8
Compare
Contributor
Author
|
@jackye1995 I updated the PR so it should be a bit simpler now , I agree at this point we don't need the abstractions of base test classes . Thanks for the review! @jzhuge @rdblue let me know your thoughts on this! |
amogh-jahagirdar
force-pushed
the
view-history-entry-core
branch
from
c95e4a8 to
6c7e37e
Compare
Contributor
|
Also ping a few people in #4925 to as we are starting to get all the implementations in |
nastra
reviewed
Jan 13, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
overall LGTM but needs a few small updates
core/src/main/java/org/apache/iceberg/view/ViewHistoryEntryParser.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/view/TestViewHistoryEntryParser.java
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
view-history-entry-core
branch
from
6c7e37e to
b8822f7
Compare
rdblue
reviewed
Jan 13, 2023
core/src/main/java/org/apache/iceberg/view/BaseViewHistoryEntry.java
Outdated
Show resolved
Hide resolved
rdblue
approved these changes
Jan 13, 2023
Contributor
|
Looks good other than the name of the history entry interface. Thanks, @amogh-jahagirdar! |
amogh-jahagirdar
force-pushed
the
view-history-entry-core
branch
from
b8822f7 to
c48b23f
Compare
amogh-jahagirdar
force-pushed
the
view-history-entry-core
branch
from
c48b23f to
144d30f
Compare
Co-authored-by: John Zhuge <[email protected]>
amogh-jahagirdar
force-pushed
the
view-history-entry-core
branch
from
144d30f to
2c334da
Compare
jackye1995
approved these changes
Jan 14, 2023
Contributor
Member
|
LGTM! |
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Co-authored-by: John Zhuge <[email protected]> (cherry picked from commit c05bde8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: John Zhuge [email protected]
Separating this PR from https://github.com/apache/iceberg/pull/6559/files#diff-2a70d3056d3d0cca0da3ff4ddabc83c41c06af2296f281a5b37c5b54ead98915 for easier review from the community.
This PR contains the core implementation for view history entry and parsing/serializing logic for view history logs.
cc : @jzhuge @rdblue @jackye1995