Dynamo/Jdbc/Ecs/Nessie: Expose catalog properties #6471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Dec 21, 2022
|
|
||
| @Override | ||
| protected Map<String, String> properties() { | ||
| return catalogProperties == null ? ImmutableMap.of() : catalogProperties; |
Contributor
Author
There was a problem hiding this comment.
this is how it's being already done in the HadoopCatalog / HiveCatalog
rdblue
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #6410 (which accesses the catalog properties via
properties()), I've noticed that not every catalog exposes their properties. This PR aligns the affected catalog with how other catalogs expose their properties.