Core: Don't produce partition summaries on unpartitioned table #6411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
partition-summary
branch
from
cfbe0a4 to
7f39853
Compare
nastra
commented
Dec 12, 2022
nastra
commented
Dec 12, 2022
|
|
||
| Assert.assertTrue( | ||
| "Partition metrics must be correct", | ||
| summary.get(CHANGED_PARTITION_PREFIX).contains(ADDED_DELETE_FILES_PROP + "=1")); |
Contributor
Author
There was a problem hiding this comment.
this was in fact checking the entry, which we don't produce anymore:
"partitions." -> "added-position-delete-files=1,added-delete-files=1,added-files-size=10,added-position-deletes=1"
The summaries map also had the following entries for the 3 partitions:
"partitions.data_bucket=0" -> "added-position-delete-files=1,added-delete-files=1,added-files-size=10,added-position-deletes=1"
"partitions.data=abc" -> "added-position-delete-files=1,added-delete-files=1,added-files-size=10,added-position-deletes=1"
"partitions.data=xyz" -> "added-data-files=1,added-records=1,added-files-size=10"
7647339 to
b18fac9
Compare
nastra
commented
Dec 12, 2022
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
partition-summary
branch
from
b18fac9 to
4406c4d
Compare
nastra
commented
Dec 12, 2022
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
partition-summary
branch
from
4406c4d to
84c572e
Compare
rdblue
reviewed
Dec 12, 2022
nastra
force-pushed
the
partition-summary
branch
from
84c572e to
e6688c6
Compare
Previously, having an unpartitioned table would produce a `"partitions."` entry in the snapshot summary when the partition summary limit was configured
nastra
force-pushed
the
partition-summary
branch
from
e6688c6 to
2c43624
Compare
rdblue
approved these changes
Dec 19, 2022
Contributor
|
Merged! Thanks, @nastra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, having an unpartitioned table would produce a
"partitions."entry in the snapshot summary when the partition summary limit was configured