Skip to content

Conversation

@ConeyLiu
Copy link
Contributor

@ConeyLiu ConeyLiu commented Dec 1, 2022

This PR just ported #4627 to Spark 2.4/3.1/3.2.

@chenjunjiedada
Copy link
Collaborator

What about 1.16?

@ajantha-bhat
Copy link
Member

What about 1.16?

I think flink-1.16 and spark-3.3 is handled in the original PR itself.
#4627

@ajantha-bhat
Copy link
Member

ajantha-bhat commented Dec 1, 2022

nit: we could at least split it into one spark and one flink PR or one PR for each version.

@ConeyLiu
Copy link
Contributor Author

ConeyLiu commented Dec 1, 2022

Thanks @chenjunjiedada @ajantha-bhat for the review.

What about 1.16?

It is already done in #4627.

nit: we could at least split it into one spark and one flink PR or one PR for each version.

OK, let me split it into two patches.

@chenjunjiedada
Copy link
Collaborator

Well, I thought flink 1.16 was supported recently. Never thought the change was already in it.

@ConeyLiu ConeyLiu changed the title Port #4627 to Spark 2.4/3.1/3.2 and Flink 1.14/1.15 Port #4627 to Spark 2.4/3.1/3.2 Dec 1, 2022
@ConeyLiu
Copy link
Contributor Author

ConeyLiu commented Dec 1, 2022

cc @szehon-ho @pvary @kbendick who reviewed the original pr.

@pvary
Copy link
Contributor

pvary commented Dec 2, 2022

@ConeyLiu - was it a clean backport, or we should specifically check some changes which are different from the original fix?

@ConeyLiu
Copy link
Contributor Author

ConeyLiu commented Dec 2, 2022

@pvary same here, just copy, no other changes.

@pvary pvary merged commit 3de462e into apache:master Dec 2, 2022
@pvary
Copy link
Contributor

pvary commented Dec 2, 2022

@ConeyLiu: Thanks for the PR

@ConeyLiu
Copy link
Contributor Author

ConeyLiu commented Dec 3, 2022

Thanks @pvary for merging this and thanks @chenjunjiedada @ajantha-bhat for the review.

@ConeyLiu ConeyLiu deleted the backport-4627 branch December 3, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants