Core: MetadataUpdateParser should write updates/removals fields rather than updated/removed #6317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
metadata-update-parser-fixes
branch
from
68eeecd to
b81623b
Compare
singhpk234
approved these changes
Nov 30, 2022
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, Thanks @nastra !
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
metadata-update-parser-fixes
branch
from
b81623b to
35c375e
Compare
| return new MetadataUpdate.SetProperties(updated); | ||
| Map<String, String> updates; | ||
| // first read UPDATED for backward compatibility | ||
| if (node.has(UPDATED)) { |
Contributor
There was a problem hiding this comment.
nit: I think you should always check the correct property first, so we don't prioritize the obsolete one. This is pretty minor because you likely wouldn't have both.
Contributor
Author
There was a problem hiding this comment.
I've slightly adjusted the code so that in the unlikely event that both fields are defined, we take the new one
nastra
force-pushed
the
metadata-update-parser-fixes
branch
from
35c375e to
75ff1d1
Compare
…r than updated/removed According to the REST API Spec the parser needs to write updates/removals rather than updated/removed. However, we indefinitely need to support reading both versions for backward compatibility.
nastra
force-pushed
the
metadata-update-parser-fixes
branch
from
75ff1d1 to
b972e14
Compare
Fokko
approved these changes
Dec 1, 2022
danielcweeks
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.