Python: Replace mmh3 with mmhash3 #6076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-replace-mmh3-with-mmhash3
branch
from
b4ac28d
to
50e6014
Compare
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Oct 29, 2022
PR apache#6076 fails because the poetry update command also bumped the version of FastAvro. I don't think this is wanted behavior, therefore I suggest to pin the versions, instead of providing a lower bound. Dependabot will take care of the bumping of the versions every week.
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Oct 31, 2022
PR apache#6076 fails because the poetry update command also bumped the version of FastAvro. I don't think this is wanted behavior, therefore I suggest to pin the versions, instead of providing a lower bound. Dependabot will take care of the bumping of the versions every week.
rdblue
pushed a commit
that referenced
this pull request
Nov 3, 2022
PR #6076 fails because the poetry update command also bumped the version of FastAvro. I don't think this is wanted behavior, therefore I suggest to pin the versions, instead of providing a lower bound. Dependabot will take care of the bumping of the versions every week.
The mmh3 project is abandoned, and not being maintained. This results in that there are no wheels (compiled binaries) available for newer versions of Python (3.10 and 3.11). I've forked the repo, and created a new release with the latest binaries. Solves apache#5901
Fokko
force-pushed
the
fd-replace-mmh3-with-mmhash3
branch
from
50e6014
to
f2fbcf3
Compare
singhpk234
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
I've forked the repo and created a new release with the binaries for the latest versions of Python.
Awesome !
Looks good to me, Thanks @Fokko !
|
is there an ETA when it will merged ? |
rdblue
approved these changes
Nov 6, 2022
|
Thanks, @Fokko! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mmh3 project is abandoned, and not being maintained.
This results in there being no wheels (compiled binaries) available for newer versions of Python (3.10 and 3.11). I've forked the repo and created a new release with the binaries for the latest versions of Python.
Solves #5901