Spark 3.2: #6041 follow-up/cleanup #6063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@flyrain sorry to trouble you again -- can you please review this? There were some simple improvements to |
flyrain
reviewed
Oct 27, 2022
| Assume.assumeTrue(format.equals("parquet")); | ||
|
|
||
| String tblName = "test_multiple_row_groups"; | ||
| String tblName = "test3"; |
Contributor
There was a problem hiding this comment.
Kinda prefer meaningful name, like table_with_multiple_row_groups, maybe we can change the 3.3 with a more meaningful name.
Contributor
Author
There was a problem hiding this comment.
The reason I changed it to test3 in the original (3.3) PR was that in the base class, the tables were test and test2, so I used test3 for this new table to be consistent!
Contributor
|
Merged. Thanks @wypoon! |
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6041, I ended up with a slightly different version of
TestSparkReaderDeletesfor v3.2 than in v3.3 because I created the PR before #6026 (the original PR, for v3.3) was merged and I then made some tweaks toTestSparkReaderDeletesfor #6026. Here I align the version ofTestSparkReaderDeletesin v3.2 with the version in v3.3. For future backports, it is easier when the 3.2 code base is the same as the 3.3 code base where there is no reason to be different.