Spark 3.1: Ensure rowStartPosInBatch in ColumnarBatchReader is set correctly #6046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wypoon
commented
Oct 25, 2022
Comment on lines
+147
to
+150
| table | ||
| .updateProperties() | ||
| .set(TableProperties.PARQUET_VECTORIZATION_ENABLED, String.valueOf(vectorized)) | ||
| .commit(); |
Contributor
Author
There was a problem hiding this comment.
TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT changed from false to true since this code was written. Thus, before, we only set TableProperties.PARQUET_VECTORIZATION_ENABLED explicitly if vectorized is true, but since TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT changed to true, all the tests in this class have been running only with vectorized reads and not with non-vectorized reads at all!
This fixes that issue.
Contributor
Author
|
@flyrain @chenjunjiedada this is the port to 3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #6026 to spark/v3.1.
This is not a direct port, as the 3.1 code base lags the 3.3 and 3.2 code base, but it is fairly straightforward.