Core: Make TableScanContext immutable #5985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
immutable-table-scan-context
branch
from
31aaad0 to
e1ab18d
Compare
nastra
changed the title
nastra
force-pushed
the
immutable-table-scan-context
branch
from
e1ab18d to
4d478d4
Compare
xxubai
approved these changes
Oct 17, 2022
Contributor
|
+1 for the refactoring refactoring. |
Contributor
Author
yes the Builder is also being generated by the Immutables library |
Fokko
approved these changes
Oct 19, 2022
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
I like it, makes it much more concise and easier to read
nastra
force-pushed
the
immutable-table-scan-context
branch
from
4d478d4 to
3bd5705
Compare
nastra
force-pushed
the
immutable-table-scan-context
branch
from
3bd5705 to
f5f0463
Compare
Contributor
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Co-authored-by: Liwei Li <[email protected]>
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Co-authored-by: Liwei Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shorter alternative to #5982