Core: Parallelize the determining of reachable manifests during file cleanup #5981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
reachability-cleanup
branch
from
f523fb8 to
2cdcd4f
Compare
amogh-jahagirdar
changed the title
rdblue
reviewed
Oct 14, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Oct 14, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
reachability-cleanup
branch
5 times, most recently
from
ed9e051 to
b061989
Compare
kbendick
reviewed
Oct 16, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
kbendick
reviewed
Oct 16, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
kbendick
reviewed
Oct 16, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
reachability-cleanup
branch
from
b061989 to
cc8f539
Compare
amogh-jahagirdar
requested review from
kbendick and
rdblue
and removed request for
kbendick and
rdblue
amogh-jahagirdar
force-pushed
the
reachability-cleanup
branch
2 times, most recently
from
10eca9a to
24a456a
Compare
rdblue
reviewed
Oct 17, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Oct 17, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Oct 17, 2022
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
reachability-cleanup
branch
2 times, most recently
from
06cc886 to
a205384
Compare
amogh-jahagirdar
force-pushed
the
reachability-cleanup
branch
from
a205384 to
3846bf7
Compare
rdblue
reviewed
Oct 19, 2022
| return; | ||
| } | ||
|
|
||
| currentManifestCallback.accept(manifestFile.copy()); |
Contributor
There was a problem hiding this comment.
Very minor, but it seems weird to copy here rather than in the callback. If the callback were a noop, we'd be doing work for nothing. Since we know it needs to be copied, it seems fine though.
rdblue
approved these changes
Oct 19, 2022
Contributor
|
Thanks, @amogh-jahagirdar! Looks great. |
Contributor
Author
|
Thanks for the reviews @rdblue @kbendick @jackye1995 ! |
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #5669.
1.) Parallelizing determining the reachable manifests given a set of snapshots
2.) Cleaning up issues in log messages #5669 (comment) and #5669 (comment)