Skip to content

Core: Increase inferred column metrics limit to 100 #5916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 3 commits into from
Oct 23, 2022
Merged

Core: Increase inferred column metrics limit to 100 #5916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78de7a8
Core: Increase inferred column metrics limit to 100.
rdblue Oct 4, 2022
8f3a898
fix tests
nastra Oct 6, 2022
60ab97b
Merge pull request #23 from nastra/fix-column-metrics
rdblue Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/iceberg/TableProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ private TableProperties() {}

public static final String METRICS_MAX_INFERRED_COLUMN_DEFAULTS =
"write.metadata.metrics.max-inferred-column-defaults";
public static final int METRICS_MAX_INFERRED_COLUMN_DEFAULTS_DEFAULT = 32;
public static final int METRICS_MAX_INFERRED_COLUMN_DEFAULTS_DEFAULT = 100;

public static final String METRICS_MODE_COLUMN_CONF_PREFIX = "write.metadata.metrics.column.";
public static final String DEFAULT_WRITE_METRICS_MODE = "write.metadata.metrics.default";
Expand Down
6 changes: 3 additions & 3 deletions data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ public void testMaxColumns() throws IOException {
File tableDir = temp.newFolder();
tableDir.delete(); // created by table create

int numColumns = 33;
int numColumns = TableProperties.METRICS_MAX_INFERRED_COLUMN_DEFAULTS_DEFAULT + 1;
List<Types.NestedField> fields = Lists.newArrayListWithCapacity(numColumns);
for (int i = 0; i < numColumns; i++) {
fields.add(required(i, "col" + i, Types.IntegerType.get()));
Expand Down Expand Up @@ -236,7 +236,7 @@ public void testMaxColumns() throws IOException {

// start at 1 because IDs were reassigned in the table
int id = 1;
for (; id <= 32; id += 1) {
for (; id <= TableProperties.METRICS_MAX_INFERRED_COLUMN_DEFAULTS_DEFAULT; id += 1) {
Assert.assertNotNull("Should have lower bound metrics", dataFile.lowerBounds().get(id));
Assert.assertNotNull("Should have upper bound metrics", dataFile.upperBounds().get(id));
Assert.assertNull(
Expand All @@ -262,7 +262,7 @@ public void testMaxColumnsWithDefaultOverride() throws IOException {
File tableDir = temp.newFolder();
tableDir.delete(); // created by table create

int numColumns = 33;
int numColumns = TableProperties.METRICS_MAX_INFERRED_COLUMN_DEFAULTS_DEFAULT + 1;
List<Types.NestedField> fields = Lists.newArrayListWithCapacity(numColumns);
for (int i = 0; i < numColumns; i++) {
fields.add(required(i, "col" + i, Types.IntegerType.get()));
Expand Down