Spark: Set the version explicitly #5907
Merged
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-set-versions
branch
2 times, most recently
from
1f27f9d to
76e1ce0
Compare
ajantha-bhat
approved these changes
Oct 3, 2022
Member
ajantha-bhat
left a comment
ajantha-bhat
left a comment
There was a problem hiding this comment.
LGTM.
Assuming we handle the read path testcase update (one more open comment) in another followup PR.
danielcweeks
approved these changes
Oct 4, 2022
Contributor
Author
|
Thanks for the review @ajantha-bhat. Looking at #4602 should solve the missing piece. I'm checking it and will fix the conflicts 👍🏻 Just wanted to fix this asap so we don't forget it. Thanks @danielcweeks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #5707