Core: Reduce duplicated code in JSON Parsers #5802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
reduce-code-duplication-in-parsers
branch
from
29176f6 to
9bf8250
Compare
findepi
reviewed
Sep 20, 2022
| } catch (IOException e) { | ||
| throw new RuntimeIOException(e); | ||
| } | ||
| return JsonUtil.generate(gen -> toJson(spec, gen), pretty); |
Member
There was a problem hiding this comment.
Nice!
BTW we have a bit duplicated code for parsing as well. I was changing it in #5048.
BTW 2: i'd use generator instead of gen. That's how it's usually called, so it will be more familiar
Member
There was a problem hiding this comment.
i'd use
generatorinstead ofgen.
i see now both are used in the codebase. disregard
Contributor
Author
There was a problem hiding this comment.
BTW we have a bit duplicated code for parsing as well. I was changing it in #5048.
ah interesting, you're right. Do you want to open maybe a separate PR for removing that part of duplicated code?
findepi
approved these changes
Sep 20, 2022
bryanck
approved these changes
Sep 20, 2022
danielcweeks
approved these changes
Sep 20, 2022
Contributor
danielcweeks
left a comment
danielcweeks
left a comment
There was a problem hiding this comment.
Thanks @nastra, nice cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #5799 and the
StatisticsFileParserI noticed that there are a bunch of places with duplicated code in the JSON Parsers. This PR aims at cleaning those up and reusingJsonUtil.generatewhere applicable