-
Notifications
You must be signed in to change notification settings - Fork 3k
Doc: Update doc to display the results of the table partitions query #5662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
15ed542 to
f14f814
Compare
szehon-ho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the docs make sense overall, one comment.
docs/spark-queries.md
Outdated
| | {20211002, 11}| 1| 1| | ||
| | {20211001, 10}| 1| 1| | ||
| | {20211002, 10}| 1| 1| | ||
| If this table is not partitioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure about adding non-partitioned example for "partitions" table , as I think its something few users would need, but it is right under the header so most people have to scroll past to see what they really want to see (the schema). Id suggest removing it for now, which would be consistent with the other tables, if it sounds reasonable to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I I keep the result of partitioned table and display the result of non-partitioned table using note to make it more understandable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed it.
893cdde to
ad65635
Compare
szehon-ho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK its fine with me, left one small nit
ad65635 to
72946da
Compare
docs/spark-queries.md
Outdated
| | {20211002, 10}| 1| 1| 0| | ||
|
|
||
| Note: | ||
| If this table is non-partitioned, it will contain only the record_count and file_count columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized "this table... it" will be wrong because we mean different tables (data table and metadata table)
How about this fix?
"For unpartitioned tables, the partitions table will contain only the record_count and file_count columns."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, addressed it.
szehon-ho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I re-read this and just one small thing to address, then I think we can merge it.
72946da to
06cffc0
Compare
|
Merged, thanks @lvyanquan |
In the pr of #4516, we added specId for partitions metadata table, but the document of query(https://iceberg.apache.org/docs/latest/spark-queries/#partitions ) hasn't been changed to adapt to that.
What's more, the ResultSet structures are not the same between partitioned and not-partitioned tables.
query example: