Core: Add expression JSON parser #5602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
commented
Aug 21, 2022
| BoundReference(Types.NestedField field, Accessor<StructLike> accessor, String name) { | ||
| this.field = field; | ||
| this.accessor = accessor; | ||
| this.name = name; |
Contributor
Author
There was a problem hiding this comment.
Tracking the field name was needed to handle bound expressions. This is also a good thing to track for other purposes (e.g., easier to read log messages with bound expressions).
Contributor
There was a problem hiding this comment.
It might be good to add a comment to distinguish this name from the field name.
danielcweeks
approved these changes
Aug 22, 2022
Contributor
danielcweeks
left a comment
danielcweeks
left a comment
There was a problem hiding this comment.
+1 LGTM. There might be a couple places where we can remove casts with the addition of name to the reference interface, but I only found one example.
Thanks everyone who contributed!
Contributor
Author
|
Thanks for reviewing, @danielcweeks! |
This was referenced Aug 22, 2022
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a JSON parser for
Expressionbased on @nastra's work in #5511, but with a few changes:CustomOrderExpressionVisitorto visit expressions when converting to JSONfromJsontoJson. Using a bound expression ensures that the JSON representation for values matches expression's typeCloses #4308
Closes #5511
Co-authored-by: Eduard Tudenhoefner [email protected]