Spark: Add Changelog reader for copy-on-write #5578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
changed the title
Contributor
|
Let me take a look. |
aokolnychyi
reviewed
Aug 25, 2022
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @aokolnychyi for the review. Resolved your comments in a new commit. Can you take a look? |
aokolnychyi
approved these changes
Aug 27, 2022
Contributor
aokolnychyi
left a comment
aokolnychyi
left a comment
There was a problem hiding this comment.
Looks good to me. I left some optional comments.
Feel free to merge whenever you are ready, @flyrain.
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/ChangelogRowReader.java
Outdated
Show resolved
Hide resolved
aokolnychyi
approved these changes
Aug 31, 2022
Contributor
|
Thanks, @flyrain! |
Contributor
|
@flyrain, could you cherry-pick this to 3.2? |
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 10, 2023
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aokolnychyi @szehon-ho @anuragmantri @RussellSpitzer @karuppayya @kbendick @rdblue