Add InternalRecordWrapperFactory to generate InternalRecordWrapper #5242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Jul 11, 2022
Co-Authored-By: shidayang <[email protected]> Closes apache#5242.
Contributor
|
@shidayang, I fixed this in #5249 and made you a co-author. Thanks for identifying this! |
Contributor
Author
|
@rdblue OK |
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Co-Authored-By: shidayang <[email protected]> Closes apache#5242.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Co-Authored-By: shidayang <[email protected]> Closes apache#5242.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 20, 2022
Co-Authored-By: shidayang <[email protected]> Closes apache#5242.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 20, 2022
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 25, 2022
Co-Authored-By: shidayang <[email protected]> Closes apache#5242.
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244. (cherry picked from commit fa07d9f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cost of creating InternalRecord is very high, So the performance of MOR is low when have many delete files.