Skip to content

API - Deprecate unused runSafely functions #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbendick wants to merge 5 commits into from
Closed

API - Deprecate unused runSafely functions #5205

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b41c30b
API - Deprecate unused runSafely functions and remove their associate…
kbendick Jul 5, 2022
018245a
Add a suppression for error prone for the unused / deprecated functio…
kbendick Jul 5, 2022
870563c
Add TestExceptionUtil back in
kbendick Jul 5, 2022
e809aba
Remove added newline
kbendick Jul 5, 2022
749e56b
Add @deprecated javadoc tag indicating when these functions will be r…
kbendick Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions api/src/main/java/org/apache/iceberg/util/ExceptionUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ public interface FinallyBlock {
void run() throws Exception;
}

/**
* This function is unused outside of the associated tests in TestExceptionUtil.
* @deprecated since 0.14.0. Will be removed in 1.0.0.
*/
@Deprecated
public static <R> R runSafely(
Block<R, RuntimeException, RuntimeException, RuntimeException> block,
CatchBlock catchBlock,
Expand All @@ -61,6 +66,11 @@ public static <R> R runSafely(
RuntimeException.class, RuntimeException.class, RuntimeException.class);
}

/**
* This function is unused outside of the associated tests in TestExceptionUtil.
* @deprecated since 0.14.0. Will be removed in 1.0.0.
*/
@Deprecated
public static <R, E1 extends Exception> R runSafely(
Block<R, E1, RuntimeException, RuntimeException> block,
CatchBlock catchBlock,
Expand All @@ -69,6 +79,11 @@ public static <R, E1 extends Exception> R runSafely(
return runSafely(block, catchBlock, finallyBlock, e1Class, RuntimeException.class, RuntimeException.class);
}

/**
* This function is unused outside the associated tests in TestExceptionUtil.
* @deprecated since 0.14.0. Will be removed in 1.0.0.
*/
@Deprecated
public static <R, E1 extends Exception, E2 extends Exception> R runSafely(
Block<R, E1, E2, RuntimeException> block,
CatchBlock catchBlock,
Expand All @@ -78,6 +93,12 @@ public static <R, E1 extends Exception, E2 extends Exception> R runSafely(
return runSafely(block, catchBlock, finallyBlock, e1Class, e2Class, RuntimeException.class);
}

/**
* This function is unused outside the associated tests in TestExceptionUtil.
* @deprecated since 0.14.0. Will be removed in 1.0.0.
*/
@Deprecated
@SuppressWarnings("Finally")
public static <R, E1 extends Exception, E2 extends Exception, E3 extends Exception> R runSafely(
Block<R, E1, E2, E3> block,
CatchBlock catchBlock,
Expand Down