Skip to content

Conversation

@rdblue
Copy link
Contributor

@rdblue rdblue commented Jul 3, 2022

This is based on #4951 from Kyle, but attempts to fix the current test failures.

@@ -1,12 +1,12 @@
org.slf4j:* = 1.7.25
org.apache.avro:avro = 1.10.1
org.apache.avro:avro = 1.10.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to update to avro 1.11.0 since it has been around for a while already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the purpose of updating Avro was to keep parquet-avro and avro in sync. That seems like a reasonable choice to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, +1

@rdblue rdblue added this to the Iceberg 0.14.0 Release milestone Jul 5, 2022
Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this working @rdblue!

@kbendick
Copy link
Contributor

kbendick commented Jul 6, 2022

For reference, the changelog from 1.12.2 to 1.12.3 is here: apache/parquet-java@apache-parquet-1.12.2...apache-parquet-1.12.3

I'm going to close #4951 in favor of this. Thanks @rdblue!

@rdblue rdblue merged commit d397ae3 into apache:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants