Skip to content

Fix typo in FlinkSink #5176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rdblue merged 1 commit into from
Jul 5, 2022
Merged

Fix typo in FlinkSink #5176

rdblue merged 1 commit into from
Jul 5, 2022

Conversation

@a49a
Copy link
Contributor

@a49a a49a commented Jul 1, 2022

Change should't to shouldn't in FlinkSink class.

@github-actions github-actions bot added the flink label Jul 1, 2022
kbendick
kbendick reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deadwind4!

Can you update this in the other Flink versions (assuming they’re similarly incorrect)? For small things like this I think it’s best to do it in one PR.

@rdblue
Copy link
Contributor

rdblue commented Jul 3, 2022

@deadwind4, can you rebase?

@a49a a49a force-pushed the typo-flinksink branch from e67773a to 07bc35d Compare July 4, 2022 00:29
@a49a
Copy link
Contributor Author

a49a commented Jul 4, 2022

@kbendick I have updated in other Flink versions. @rdblue I have rebased. Thanks a lot.

@kbendick
Copy link
Contributor

kbendick commented Jul 4, 2022

@kbendick I have updated in other Flink versions. @rdblue I have rebased. Thanks a lot.

Thanks @deadwind4!

@rdblue rdblue merged commit da7dd94 into apache:master Jul 5, 2022
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
@a49a
Flink: Fix typo in FlinkSink string (apache#5176)
17708f5
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
@a49a
Flink: Fix typo in FlinkSink string (apache#5176)
b2e057a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdblue rdblue rdblue approved these changes

@nastra nastra nastra approved these changes

@Fokko Fokko Fokko approved these changes

+1 more reviewer

@kbendick kbendick kbendick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flink

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@a49a @rdblue @kbendick @nastra @Fokko