Use manifest lists by default and fix tests. #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Accidentally duplicated this one in #51. Closing. |
puchengy
added a commit
to puchengy/iceberg
that referenced
this pull request
Jun 7, 2023
* Handle thrift schema backed table reads in vectorized reader (apache#26) (cherry picked from commit 432a48b) * lint --------- Co-authored-by: Ashish Singh <[email protected]>
jbonofre
pushed a commit
to jbonofre/iceberg
that referenced
this pull request
Feb 18, 2025
(cherry picked from commit 639b0d5b41b827d984aae04efe594315ec2b2b91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes tests that were picking up manifest list files because they validated manifests in the metadata directory by looking for all Avro files. Those tests now use
listManifestFilesthat will filter out manifest lists.This fixes a minor bug in Snapshot.cacheChanges, where manifests was accessed directly instead of using the lazy-loading method.