Skip to content

Hive: Fix an error when create external table in hive catalog #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renshangtao wants to merge 2 commits into from
Closed

Hive: Fix an error when create external table in hive catalog #4916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae34cf
Hive create external table will return an error AlreadyExistsException
renshangtao May 31, 2022
aa1745c
Fix an error when run test casetestCreateTableAboveExistingTable .
renshangtao May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,24 @@ public void preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable)
// so that the table can be read by other engines like Impala
hmsTable.getSd().setInputFormat(HiveIcebergInputFormat.class.getCanonicalName());
hmsTable.getSd().setOutputFormat(HiveIcebergOutputFormat.class.getCanonicalName());
}

// If not using HiveCatalog check for existing table
try {
this.icebergTable = Catalogs.loadTable(conf, catalogProperties);
// Check for existing table
try {
this.icebergTable = Catalogs.loadTable(conf, catalogProperties);

if (!Catalogs.hiveCatalog(conf, catalogProperties)) {
Preconditions.checkArgument(catalogProperties.getProperty(InputFormatConfig.TABLE_SCHEMA) == null,
"Iceberg table already created - can not use provided schema");
"Iceberg table already created - can not use provided schema");
Preconditions.checkArgument(catalogProperties.getProperty(InputFormatConfig.PARTITION_SPEC) == null,
"Iceberg table already created - can not use provided partition specification");
"Iceberg table already created - can not use provided partition specification");
}

LOG.info("Iceberg table already exists {}", icebergTable);
LOG.info("Iceberg table already exists {}", icebergTable);

return;
} catch (NoSuchTableException nte) {
// If the table does not exist we will create it below
}
return;
} catch (NoSuchTableException nte) {
// If the table does not exist we will create it below
}

// If the table does not exist collect data for table creation
Expand Down