[DOC] Update Hive doc page with the 4.0.0-alpha-1 features #4915
Conversation
szlta
left a comment
szlta
left a comment
There was a problem hiding this comment.
Generally looks good, some minor remarks.
Thanks @szlta for the review! Thanks, |
szlta
left a comment
szlta
left a comment
There was a problem hiding this comment.
Looks good, thanks for the corrections.
+1 non-binding
PS: feel free to resolve my comments - seems like I don't have permission to do so...
|
Thanks @pvary for your work! |
docs/hive/_index.md
Outdated
| * Creating a table | ||
| * Dropping a table | ||
| * Reading a table | ||
| * Inserting into a table (will append rows) (MapReduce only) |
There was a problem hiding this comment.
Can (will append rows) and (MapReduce only) be expanded to warning/info boxes? Something along the lines of:
{{< hint info >}}
Inserting into a table will append rows to the relevant partitions.
{{< /hint >}}
{{< hint warning >}}
Inserting into a table works with MapReduce only.
{{< /hint >}}
There was a problem hiding this comment.
The first parenthesis was trying to highlight the difference between the INSERT INTO and the INSERT OVERWRITE.
Could you please check?
docs/hive/_index.md
Outdated
| * Inserting into a table (will append rows) (MapReduce only) | ||
|
|
||
| Iceberg compatibility with Hive 4.0.0-alpha-1 | ||
| (Using HiveCatalog) supports the following, additional features: |
There was a problem hiding this comment.
nit: I'd word this as
With Hive version 4.0.0-alpha-1 and above, the Iceberg
HiveCatalogsupports the following additional features:
There was a problem hiding this comment.
Reworded to this:
With Hive version 4.0.0-alpha-1 and above,
the Iceberg integration when using HiveCatalog supports the following additional features:
The point here is that some of the features are dependent on HiveCatalog, but HiveCatalog is not the full integration. You can use a different catalog implementation (say HadoopCatalog), and most of the features will work, but for example the Hive schema / Iceberg schema sync will work only with HiveCatalog.
Is this better? Any other suggestions?
docs/hive/_index.md
Outdated
| * Migrating tables in Avro, Parquet, or ORC (Non-ACID) format to Iceberg | ||
| * Reading the schema of a table | ||
| * Time travel applications | ||
| * Inserting into a table (will append rows) (Tez only) |
There was a problem hiding this comment.
Similar to my other comment, I would put these in warning or info boxes instead of tacking them onto the end of the line. Those boxes are more visible disclaimers.
|
|
||
| You need to do the following steps: | ||
| * Loading runtime jar | ||
| * Enabling support |
There was a problem hiding this comment.
This could just be one line right?
In order to use Hive 2.3.x or Hive 3.1.x, you must load the Iceberg-Hive runtime jar and enable Iceberg support, either globally or for an individual table using a table property.
and then jump into the sections below that provide more details.
|
@samredai: Could you please check again? Went through your comments, and added 2 new paragraphs. |
|
@samredai: I have checked the conflicts caused by #5115. What about the other changes? Thanks, |
|
We'll have to wait for @rdblue or another committer to review it and merge |
|
Thanks @samredai for the help. With Ryan's review, I was able to merge apache/iceberg-docs#98 |
|
Looks good to me. Can you rebase? I don't think that we need the _index.md file any more. @samredai, how should we update this? |
|
Instead of |
|
@samredai: Any other change that we have to keep from the changes came in for docs/hive/_index.md? What I see are only formatting changes |
|
Ah that's right, this has already been added by PR #5115 . That includes all of the changes from this PR here so this should be good to close. |
5 participants
Update Hive doc page with the 4.0.0-alpha-1 features