API: Pass FileIO into Snapshot methods that read metadata - Backport #4877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
force-pushed
the
kb-deprecate-fileio-state-in-basesnapshot-backport
branch
from
8cc3fff to
e1db6a3
Compare
kbendick
commented
May 26, 2022
| } | ||
|
|
||
| return currentSnapshot.dataManifests().stream() | ||
| return currentSnapshot.dataManifests(fileIO).stream() |
Contributor
Author
There was a problem hiding this comment.
For this usage, there's a class level fileIO that is wrapped to avoid Kryo serialization issues. So we use that instead of table..io().
Contributor
Author
|
It's worth noting that this changes only 4 lines of code that are in source files. The rest is in test files. I've checked those 4 lines for serialization concerns and there are none (other than the commented area in |
rdblue
approved these changes
May 27, 2022
Contributor
|
Thanks, @kbendick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #4873 to Spark 2.4, 3.0, and 3.1 as well as Flink 1.13 and 1.14.
The only usage of the deprecated functions that remains is the call to
snapshot.allManifests()in SnapshotParser at line 86, which we explicitly chose to leave in for now as there should be very few tables that do not already have the manifest list in them (and are storing manifests instead).cc @rdblue @nastra @danielcweeks