add VoidTransform #4727
Merged
add VoidTransform #4727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jun-he
force-pushed
the
jun/add-void-transform
branch
from
e91b73a to
bcaa0ce
Compare
Fokko
reviewed
May 9, 2022
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Some small comments, but looks good in general 👍🏻
python/src/iceberg/transforms.py
Outdated
| def __init__(self): | ||
| super().__init__("void", "transforms.always_null()") | ||
|
|
||
| def apply(self, value): |
Contributor
There was a problem hiding this comment.
Related to #4728
Suggested change
| def apply(self, value): | |
| def apply(self, value: Optional[S]) -> Optional[int]: |
Collaborator
Author
There was a problem hiding this comment.
Thanks for the comment. Updated.
|
|
||
| _instance = None | ||
|
|
||
| def __new__(cls): |
Contributor
There was a problem hiding this comment.
We could add a test for this:
def test_check_if_identical():
assert transforms.always_null() is transforms.always_null()
Collaborator
Author
There was a problem hiding this comment.
👍 Updated the test.
python/src/iceberg/transforms.py
Outdated
| def result_type(self, source: IcebergType) -> IcebergType: | ||
| return source | ||
|
|
||
| def to_human_string(self, value) -> str: |
Contributor
There was a problem hiding this comment.
Suggested change
| def to_human_string(self, value) -> str: | |
| def to_human_string(self, Optional[value]) -> str: |
Contributor
jun-he
force-pushed
the
jun/add-void-transform
branch
from
bcaa0ce to
7e13846
Compare
Collaborator
Author
rdblue
approved these changes
May 13, 2022
Contributor
|
Thanks, @jun-he! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To split the PR #3450, open a new PR for void transform here.