Skip to content

Core: Log the new metadata location in commit. #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 2 commits into from
May 4, 2022
Merged

Core: Log the new metadata location in commit. #4681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
626c981
Log the new metadata location in commit.
flyrain May 2, 2022
c2e6ed0
Resolve the comments
flyrain May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ public void commit(TableMetadata base, TableMetadata metadata) {
// this rename operation is the atomic commit operation
renameToFinal(fs, tempMetadataFile, finalMetadataFile, nextVersion);

LOG.info("Committed a new metadata file {}", finalMetadataFile);

// update the best-effort version pointer
writeVersionHint(nextVersion);

Expand Down
2 changes: 2 additions & 0 deletions hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,8 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
} finally {
cleanupMetadataAndUnlock(commitStatus, newMetadataLocation, lockId, tableLevelMutex);
}

LOG.info("Committed to table {} with the new metadata location {}", fullName, newMetadataLocation);
Copy link
Contributor Author

@flyrain flyrain May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of putting this log in both line 278 and line 297, I put the log here.

}

@VisibleForTesting
Expand Down