Core: Add ByteBufferInputStream and implementations #4623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
add-byte-buffer-streams
branch
2 times, most recently
from
6347c26 to
1fdf6cc
Compare
rdblue
force-pushed
the
add-byte-buffer-streams
branch
from
1fdf6cc to
ee9c0b2
Compare
rdblue
force-pushed
the
add-byte-buffer-streams
branch
from
17929bd to
24161f3
Compare
danielcweeks
approved these changes
Apr 28, 2022
Contributor
Author
|
Thanks @danielcweeks! |
| } | ||
|
|
||
| public void seek(long newPosition) throws IOException { | ||
| if (newPosition > length) { |
Contributor
There was a problem hiding this comment.
might want a check for a -ve position here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies an abstract class,
ByteBufferInputStream, and its two implementations,SingleBufferInputStreamandMultiBufferInputStreamfrom Parquet. This is to support the in-memory streams that are proposed for tests (#4534) and for adding caching toFileIO(#4518).This also copies the tests and updates the LICENSE file.