Add RangeReadable interface for range base FileIO reads #4608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
reviewed
Apr 21, 2022
kbendick
reviewed
Apr 21, 2022
Contributor
Author
|
@electrum I just an FYI, this adds the range based read and simplifies this path significantly as compared to AWS SDK v1 since much of the stream copy logic is handled by SDK v2. This possibly save an array copy as well. |
rdblue
reviewed
Apr 22, 2022
rdblue
reviewed
Apr 22, 2022
rdblue
reviewed
Apr 22, 2022
rdblue
reviewed
Apr 22, 2022
danielcweeks
commented
Apr 23, 2022
danielcweeks
commented
Apr 23, 2022
openinx
reviewed
Apr 24, 2022
openinx
reviewed
Apr 24, 2022
Replace readFully implementation with one from Parquet, with tests
rdblue
approved these changes
Apr 25, 2022
Contributor
|
Thanks, @danielcweeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional interface,
RangeReadable, which allows for positional, range-based reads to support object stores like S3 that prefer bounded reads.