Python: Refactor to use common decimal and datetime util #4480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
python-minor-refactor
branch
2 times, most recently
from
5473911 to
b16164f
Compare
rdblue
force-pushed
the
python-minor-refactor
branch
2 times, most recently
from
c4ed6df to
4787d24
Compare
rdblue
force-pushed
the
python-minor-refactor
branch
from
4787d24 to
4a2441d
Compare
Collaborator
|
LGTM, thanks @rdblue |
samredai
reviewed
Apr 4, 2022
samredai
approved these changes
Apr 4, 2022
Contributor
samredai
left a comment
samredai
left a comment
There was a problem hiding this comment.
One suggestion but otherwise LGTM
danielcweeks
reviewed
Apr 4, 2022
danielcweeks
approved these changes
Apr 4, 2022
Contributor
danielcweeks
left a comment
danielcweeks
left a comment
There was a problem hiding this comment.
Minor question on funciton name (non-blocker), but looks good to me.
Contributor
Author
|
Thanks for reviewing, @jun-he, @samredai, and @danielcweeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of minor comments from #4416 and refactors to use common decimal and datetime util functions.