Skip to content

Update doc to state that day partition transform produces data type #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 2 commits into from
Sep 13, 2019
Merged

Update doc to state that day partition transform produces data type #447

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b59f7ba
Update doc to state that day partition transform produces data type
waterlx Sep 4, 2019
7dca405
Update doc to state that day partition transform produces data type -…
waterlx Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/docs/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Partition specs capture the transform from table data to partition values. This
| **`truncate[W]`** | Value truncated to width `W` (see below) | `int`, `long`, `decimal`, `string` | Source type |
| **`year`** | Extract a date or timestamp year, as years from 1970 | `date`, `timestamp(tz)` | `int` |
| **`month`** | Extract a date or timestamp month, as months from 1970-01-01 | `date`, `timestamp(tz)` | `int` |
| **`day`** | Extract a date or timestamp day, as days from 1970-01-01 | `date`, `timestamp(tz)` | `int` |
| **`day`** | Extract a date or timestamp day, as date | `date`, `timestamp(tz)` | `date` |

@rdblue rdblue Sep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should change the type but not description.

@waterlx waterlx Sep 6, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdblue Comment addressed, Only "Return type" is changed. Please review at your most convenience, thanks!

@waterlx waterlx Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdblue Would you please help to review this change at your most convenience?

@waterlx waterlx Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rdblue Would you please help to review the change at your most convenience ? The comment addressed.

| **`hour`** | Extract a timestamp hour, as hours from 1970-01-01 00:00:00 | `timestamp(tz)` | `int` |

All transforms must return `null` for a `null` input value.
Expand Down