Core: Update REST catalog to use 204/404 for DELETE #4412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
remove-rest-delete-results
branch
from
58bf083 to
5bb530d
Compare
Contributor
Author
|
Thanks for reviewing, @danielcweeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the REST catalog implementation for #4366 by removing the delete response objects. Whether the object was deleted or not found is now communicated by response code. 204 indicates that the object was successfully deleted. 404 indicates that the object did not exist.
Purge is still not implemented, but will use 202 to return a callback for checking on a purge operation that has not yet completed.