Spark 3.2: Cleanup DataFrame overwritePartitions isolation level handling #4310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
changed the title
Member
Author
|
@aokolnychyi fyi |
kbendick
approved these changes
Mar 13, 2022
Contributor
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for following up @szehon-ho!
| if (validateFromSnapshotId != null) { | ||
| dynamicOverwrite.validateFromSnapshot(validateFromSnapshotId); | ||
| } | ||
| dynamicOverwrite.validateNoConflictingData(); |
Contributor
There was a problem hiding this comment.
Nit: It seems like this one is repeated in both cases. Since there's no existing else clause, it's probably not worth reducing the duplication as we might need more if statements but thought I'd call it out.
Member
Author
There was a problem hiding this comment.
Thanks yea good catch, I was thinking to leave it here to make it more clear in each validation mode what we are validating, and maybe there are future modes where we do not do this as you said. As opposed to the validationSnapshotId which is the basis of all validations.
szehon-ho
changed the title
szehon-ho
changed the title
szehon-ho
changed the title
Member
Author
|
Thanks @kbendick for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some minor cleanup and add one more test for #2925
This is from comment #4293 (comment) of splitting these changes from that pr into a separate one.