Skip to content

Conversation

@openinx
Copy link
Member

@openinx openinx commented Mar 9, 2022

This PR is trying to add the disk-based insertedRowMap (which was published here before) on top of the newly introduced PartitioningWriter interfaces.

@rdblue
Copy link
Contributor

rdblue commented Apr 15, 2022

@openinx, is this related to the other PR that refactors the writers? Should we work on this one or the other one first?

Also, is there any way to break this into smaller PRs for review? This is quite large and I'm concerned about getting it reviewed since it is big.

@openinx
Copy link
Member Author

openinx commented Apr 18, 2022

@rdblue thanks for your attentions for this part. The base PR is here: #4264 . I think we need to get that one reviewed & merged firstly, so that we can optimize the write path for further features.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 7, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants