Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/src/main/java/org/apache/iceberg/transforms/Dates.java
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ public boolean canTransform(Type type) {

@Override
public Type getResultType(Type sourceType) {
if (granularity == ChronoUnit.DAYS) {
return Types.DateType.get();
}
return Types.IntegerType.get();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ public boolean canTransform(Type type) {

@Override
public Type getResultType(Type sourceType) {
if (granularity == ChronoUnit.DAYS) {
return Types.DateType.get();
}
return Types.IntegerType.get();
}

Expand Down
18 changes: 18 additions & 0 deletions api/src/test/java/org/apache/iceberg/transforms/TestDates.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
package org.apache.iceberg.transforms;

import org.apache.iceberg.expressions.Literal;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
import org.junit.Assert;
import org.junit.Test;
Expand Down Expand Up @@ -53,4 +54,21 @@ public void testNullHumanString() {
Assert.assertEquals("Should produce \"null\" for null",
"null", Transforms.day(type).toHumanString(null));
}

@Test
public void testDatesReturnType() {
Types.DateType type = Types.DateType.get();

Transform<Integer, Integer> year = Transforms.year(type);
Type yearResultType = year.getResultType(type);
Assert.assertEquals(Types.IntegerType.get(), yearResultType);

Transform<Integer, Integer> month = Transforms.month(type);
Type monthResultType = month.getResultType(type);
Assert.assertEquals(Types.IntegerType.get(), monthResultType);

Transform<Integer, Integer> day = Transforms.day(type);
Type dayResultType = day.getResultType(type);
Assert.assertEquals(Types.DateType.get(), dayResultType);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
package org.apache.iceberg.transforms;

import org.apache.iceberg.expressions.Literal;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
import org.junit.Assert;
import org.junit.Test;
Expand Down Expand Up @@ -82,4 +83,25 @@ public void testNullHumanString() {
Assert.assertEquals("Should produce \"null\" for null",
"null", Transforms.hour(type).toHumanString(null));
}

@Test
public void testTimestampsReturnType() {
Types.TimestampType type = Types.TimestampType.withZone();

Transform<Integer, Integer> year = Transforms.year(type);
Type yearResultType = year.getResultType(type);
Assert.assertEquals(Types.IntegerType.get(), yearResultType);

Transform<Integer, Integer> month = Transforms.month(type);
Type monthResultType = month.getResultType(type);
Assert.assertEquals(Types.IntegerType.get(), monthResultType);

Transform<Integer, Integer> day = Transforms.day(type);
Type dayResultType = day.getResultType(type);
Assert.assertEquals(Types.DateType.get(), dayResultType);

Transform<Integer, Integer> hour = Transforms.hour(type);
Type hourResultType = hour.getResultType(type);
Assert.assertEquals(Types.IntegerType.get(), hourResultType);
}
}