Spark 3.2: Fix names of methods that read all content files in actions #4198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
RussellSpitzer
approved these changes
Feb 22, 2022
Member
|
All changes are private or protected so I don't think we have any issues with doing the rename. LGTM |
szehon-ho
approved these changes
Feb 22, 2022
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Agree, looks good for internal refactor.
Grepping for 'data file', there are some comments on top of "BaseDeleteOrphanFilesSparkAction" and "BaseExpireSnapshotsSparkAction" that still refer to 'data file' not sure if they need to change or it's ok as is. In either case, this change LGTM
kbendick
approved these changes
Feb 22, 2022
Contributor
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
LGTM if all changes are package private etc. This is more coherent. Thanks @aokolnychyi!
Contributor
|
Not directly related to this PR. The interface DataFile seems still a bit confusing since it can be a delete file. . |
Contributor
Author
|
Fixed Javadoc, @szehon-ho. |
flyrain
approved these changes
Feb 22, 2022
Contributor
Author
|
Thanks for the reviews, everyone! |
arminnajafi
pushed a commit
to arminnajafi/iceberg
that referenced
this pull request
Feb 23, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 10, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 11, 2022
aokolnychyi
pushed a commit
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the name of the method that reads both data and delete files but claims to read only data files.