CORE: REST Catalog - Response class for server provided configuration #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
commented
Feb 22, 2022
Comment on lines
88
to
95
| public Map<String, String> merge(Map<String, String> clientProperties) { | ||
| Preconditions.checkNotNull(clientProperties, | ||
| "Cannot merge client properties with server-provided properties. Invalid client configuration: null"); | ||
| Map<String, String> merged = Maps.newHashMap(defaults); | ||
| merged.putAll(clientProperties); | ||
| merged.putAll(overrides); | ||
| return merged; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This function might be better placed outside of the response object. I haven't included tests for it yet, in case we want to move it to some other utility class or elsewhere (as the request / response object should arguably be more like data classes).
Contributor
There was a problem hiding this comment.
I'm fine with it here for now. We can move it later if we think it doesn't fit.
Contributor
Author
There was a problem hiding this comment.
Ok. That makes sense for me. This will at least unblock others from working in parallel on this.
kbendick
force-pushed
the
add-rest-catalog-config-resposne
branch
2 times, most recently
from
ad185b1 to
2f38ccc
Compare
rdblue
reviewed
Feb 23, 2022
core/src/main/java/org/apache/iceberg/rest/responses/RESTCatalogConfigResponse.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 23, 2022
core/src/main/java/org/apache/iceberg/rest/responses/RESTCatalogConfigResponse.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 23, 2022
core/src/main/java/org/apache/iceberg/rest/responses/RESTCatalogConfigResponse.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 23, 2022
core/src/main/java/org/apache/iceberg/rest/responses/RESTCatalogConfigResponse.java
Show resolved
Hide resolved
rdblue
reviewed
Feb 23, 2022
core/src/test/java/org/apache/iceberg/rest/responses/TESTRESTCatalogConfigResponse.java
Outdated
Show resolved
Hide resolved
kbendick
added a commit
to kbendick/iceberg
that referenced
this pull request
Feb 24, 2022
kbendick
force-pushed
the
add-rest-catalog-config-resposne
branch
from
8c56b5f to
27e688b
Compare
rdblue
reviewed
Feb 24, 2022
core/src/main/java/org/apache/iceberg/rest/responses/RESTCatalogConfigResponse.java
Outdated
Show resolved
Hide resolved
rdblue
approved these changes
Feb 24, 2022
kbendick
force-pushed
the
add-rest-catalog-config-resposne
branch
from
60ee8ec to
4df1d8e
Compare
kbendick
added a commit
to kbendick/iceberg
that referenced
this pull request
Feb 24, 2022
kbendick
added a commit
to kbendick/iceberg
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the response class used to populate the server-provided configuration.
Per the spec, the catalog client will call the
/v1/configendpoint to retrieve a set ofoverridesanddefaults. Thedefaultconfigurations are there to allow clients to not have to provide all details so that end user's don't have to specify values that are commonly used, and theoverridesare there so that the server can require a certain value be used.I've also started updating the REST catalog spec to be more detailed for this part (though I'll probably move that to another PR).