Skip to content

Conversation

@dungdm93
Copy link
Contributor

Inspire from ClusteredPositionDeleteWriter and ClusteredEqualityDeleteWriter, this PR add 2 FanoutWriter that write delete files which could be used in streaming (e.g Flink)

Signed-off-by: Đặng Minh Dũng [email protected]

@github-actions github-actions bot added the core label Feb 11, 2022
@dungdm93 dungdm93 force-pushed the fanout-delete-writer branch from f0b42d2 to 1191573 Compare February 11, 2022 03:18
@dungdm93
Copy link
Contributor Author

cc @aokolnychyi

@rdblue
Copy link
Contributor

rdblue commented Feb 15, 2022

@dungdm93, are these needed? You said they "could be used" but we don't want to add classes unless they are actually going to be used by some engine.

@pvary
Copy link
Contributor

pvary commented Feb 16, 2022

@rdblue: Not sure about the FanoutEqualityDeleteWriter, but we are thinking about implementing deletes for low cardinality tables. FanoutPositionDeleteWriter might be useful there. Would that make sense there? That said we are only in the "scratching the surface" phase, so we might go into another direction when we start seriously working on it.

@dungdm93
Copy link
Contributor Author

@rdblue @pvary actually, it's a part of #4132, let's go there for the discussion.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 7, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants