-
Notifications
You must be signed in to change notification settings - Fork 3k
Docs: add new site markdown files #4062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Did a direct copy using: License missing for all redirect files: My view is that we can remove these files in the Iceberg repo, when we sync to |
|
All of the markdown files that contain content can just have the license headers added right below the hugo front matter and it will be detected by the license check. That's also true for the We should be able to solve this by adding |
|
Yes I noticed the UI changes when trying to add license to those files, that's why I was suggesting to not include those files in the main repo. But I did not know we can exclude files from license checks, that sounds like a much better solution, I will do that instead, thanks for the suggestion! |
| --- | ||
| url: blogs | ||
| weight: 200 | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file need to be in the rat excludes too because the license isn't at the start?
EDIT: Sorry. I see that the rat step passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, license just need to exist, no need to be at start
|
lgtm, thanks @jackye1995! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thanks @jackye1995!
I haven't opened this locally, but at least the change from documentation -> docs I can say I looked through pretty closely (and the content).
Can run locally if needed but we can update if something seems off.
@samredai @rdblue
Second step for new documentation site migration, add contents:
iceberg-docs/docs/content/docstoiceberg/documentation/versionediceberg-docs/landing-page/content/commontoiceberg/documentation/commonAlso update labeler for documentation to point to
documentation/**/*