Flink: Port TestProjectMetaColumn to Flink 1.14 to check whether should remove meta columns in source reader #3893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d remove meta columns in source reader
hililiwei
changed the title
Member
|
Thanks @hililiwei for the port, looks good to me. |
openinx
approved these changes
Jan 20, 2022
Member
|
One minor thing, when we port the patch, we usually log the message as: So in theory, in this PR. we recommend to title it as : |
Contributor
Author
Got it. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port 1778185 to Flink 1.14
as #3477 (comment)