AWS: show old fields in Glue table #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
reviewed
Jan 13, 2022
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
Show resolved
Hide resolved
jackye1995
reviewed
Jan 13, 2022
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
Outdated
Show resolved
Hide resolved
Contributor
|
Similar to the other PR, could you add integration tests for it? |
natsukawa-kanou
force-pushed
the
old-fields
branch
from
2ade318 to
f07370c
Compare
jackye1995
reviewed
Jan 24, 2022
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jan 24, 2022
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
Outdated
Show resolved
Hide resolved
Contributor
|
@natsukawa-kanou unit test failed, I think you need to fix old tests for this change |
Contributor
|
thanks for the quick fix! overall looks good to me, running AWS integ test now. |
Contributor
|
AWS integ test passes and CI passes, approving |
jackye1995
approved these changes
Jan 24, 2022
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
thanks for the fix, approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #3887
My organization wants to have Glue show old fields for Iceberg tables, so that people know what were the columns that were already used in the past and avoid adding the same name column.
@jackye1995 @yyanyy