[SPARK] Add in NOT_STARTS_WITH support to Spark 3.1 #3782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
commented
Dec 21, 2021
Contributor
Author
There was a problem hiding this comment.
Maybe we could have testPartitionedByDataNotStartsWithFilter in Spark 3.1 and testPartitionedByIdNotStartsWith in Spark 3.0?
This patch doesn't merit so many test cases in older versions (at least as far back as Spark 3).
My preferred approach: We could also just manually verify Spark 3.0 and then only add these tests in Spark 3.1 and just do the patch for Spark 3.0.
rdblue
approved these changes
Dec 21, 2021
Contributor
|
Thanks, @kbendick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for Spark 3.0 to backport the small changes needed to make
NOT_STARTS_WITHwork with Spark 3.1Parent: #2062